Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pollux): zkp verification #113

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat(pollux): zkp verification #113

merged 1 commit into from
Jan 17, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Jan 16, 2024 •
edited
Loading

Overview

ZKP Verification.

This PR also fixes a issue with Link secret that was not saving correctly.
And Updates the demo app for the zkp verification code.

Fixes ATL-5203

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to the above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to the above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to the above: I have added tests to cover my changes
  • If yes to the above: I have taken care to cover edge cases in my tests

hamada147
hamada147 reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR is missing a t in feat

AtalaPrismSDK/Pollux/Sources/Models/AnonCreds/AnoncredsPresentation.swift Outdated
@@ -12,6 +12,7 @@ struct AnoncredsPresentation {
) throws -> String {
let linkSecret = try LinkSecret.newFromValue(valueString: linkSecret)
let request = try PresentationRequest(jsonString: request)
print(try request.getJson())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove print from the commit

@goncalo-frade-iohk goncalo-frade-iohk changed the title fea(pollux): zkp verification feat(pollux): zkp verification Jan 16, 2024
@goncalo-frade-iohk goncalo-frade-iohk merged commit 395976a into main Jan 17, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-5203 branch January 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalo-frade-iohk @hamada147